Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test against php 8.3 in not experimental mode #3778

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Test against php 8.3 in not experimental mode #3778

merged 2 commits into from
Nov 13, 2023

Conversation

sergiy-petrov
Copy link
Contributor

@sergiy-petrov sergiy-petrov commented Oct 27, 2023 •
edited
Loading

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

@PowerKiKi PowerKiKi merged commit 5b27082 into PHPOffice:master Nov 13, 2023
12 checks passed
@PowerKiKi
Copy link
Member

PHP 8.3 will be released on Nov 23 2023. So it's the right time to merge this. Thanks.

@PowerKiKi PowerKiKi mentioned this pull request Nov 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sergiy-petrov @PowerKiKi