-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #4279 from oleibman/currsymbol
Unexpected Charset Possible for Currency Symbol
- Loading branch information
Showing
5 changed files
with
94 additions
and
38 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55 changes: 55 additions & 0 deletions
55
tests/PhpSpreadsheetTests/Shared/StringHelperLocaleTest.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace PhpOffice\PhpSpreadsheetTests\Shared; | ||
|
|
||
| use PhpOffice\PhpSpreadsheet\Shared\StringHelper; | ||
| use PHPUnit\Framework\Attributes; | ||
| use PHPUnit\Framework\TestCase; | ||
|
|
||
| // separate processes due to setLocale | ||
| #[Attributes\RunTestsInSeparateProcesses] | ||
| class StringHelperLocaleTest extends TestCase | ||
| { | ||
| /** | ||
| * @var false|string | ||
| */ | ||
| private $currentLocale; | ||
|
|
||
| protected function setUp(): void | ||
| { | ||
| $this->currentLocale = setlocale(LC_ALL, '0'); | ||
| } | ||
|
|
||
| protected function tearDown(): void | ||
| { | ||
| if (is_string($this->currentLocale)) { | ||
| setlocale(LC_ALL, $this->currentLocale); | ||
| } | ||
| StringHelper::setCurrencyCode(null); | ||
| } | ||
|
|
||
| public function testCurrency(): void | ||
| { | ||
| if ($this->currentLocale === false || !setlocale(LC_ALL, 'de_DE.UTF-8', 'deu_deu.utf8')) { | ||
| self::markTestSkipped('Unable to set German UTF8 locale for testing.'); | ||
| } | ||
| $result = StringHelper::getCurrencyCode(); | ||
| self::assertSame('€', $result); | ||
| if (!setlocale(LC_ALL, $this->currentLocale)) { | ||
| self::markTestSkipped('Unable to restore default locale.'); | ||
| } | ||
| $result = StringHelper::getCurrencyCode(); | ||
| self::assertSame('€', $result, 'result persists despite locale change'); | ||
| StringHelper::setCurrencyCode(null); | ||
| $result = StringHelper::getCurrencyCode(); | ||
| self::assertSame('$', $result, 'locale now used'); | ||
| StringHelper::setCurrencyCode(null); | ||
| if (!setlocale(LC_ALL, 'deu_deu', 'de_DE@euro')) { | ||
| self::markTestSkipped('Unable to set German single-byte locale for testing.'); | ||
| } | ||
| $result = StringHelper::getCurrencyCode(true); // trim if alt symbol is used | ||
| self::assertSame('EUR', $result, 'non-UTF8 result ignored'); | ||
| } | ||
| } |