Add PySB testcases #27
Conversation
| - _measurements.tsv | ||
| observable_files: | ||
| - _observables.tsv | ||
| sbml_files: |
There was a problem hiding this comment.
Shall we change that to pysb_files directly?
There was a problem hiding this comment.
Would leave as is for now, so the yaml is still syntactically correct for the current PEtab. Definitely needs changing in the future, but it needs to be discussed how that would look like, but I would avoid changing things twice.
| @@ -9,7 +9,7 @@ | |||
|
|
|||
| # problem -------------------------------------------------------------------- | |||
|
|
|||
| model = DEFAULT_MODEL_FILE | |||
| model = DEFAULT_SBML_FILE | |||
There was a problem hiding this comment.
Unused everywhere... really needs some cleanup 😬 (elsewhere)
so we can reuse the observable formulas without modification
This reverts commit d10d55d.
'F821 undefined name' due to use of auto-export
Just copies of the original, as the alternative sbml model does not make sense here
|
Adds (experimental) PySB-PEtab versions of the test cases. Cases with Species IDs in the condition table are incompatible with PySB. They are still included here, and must fail. The model file is still provided under |
|
@FFroehlich : Can't request your review - good to go? |
| @@ -0,0 +1 @@ | |||
| . | |||
There was a problem hiding this comment.
symlink cases/sbml -> cases/ instead of moving the cases directories to cases/sbml and breaking backward compatibility ;)
There was a problem hiding this comment.
ahh. Yes, I thought this was supposed to be somewhere, but github shows this weirdly.
No description provided.