Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manager for sport_obj, event_grp_obj and event_obj #32

Open
wants to merge 18 commits into
base: beatrice
Choose a base branch
from

Conversation

Dimfred
Copy link

@Dimfred Dimfred commented Jan 23, 2019

Introduces a manager attribute for the objects above.
Every manager, higher in the object hierachy can also modify objects below (sport can mod eventgrp & event).

@xeroc
Copy link
Contributor

xeroc commented Feb 1, 2019

Excellent work on the pull request ... need community/management to agree on it for merging.

@Dimfred can you provide a specification so we have a PIP?

@xeroc xeroc closed this Feb 1, 2019
@xeroc xeroc reopened this Feb 1, 2019
Copy link

@pmconrad pmconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these changes are modifying consensus rules and need hardfork protection.

@xeroc
Copy link
Contributor

xeroc commented Feb 27, 2019

Interestingly, We have Rules objects that do not have a parent (and thus cannot be managed). As a consequence, witness-account needs to approve every new Rule on the chain!

@xeroc xeroc force-pushed the feature/manager-for-sports-and-underlying branch from d47948d to 7a3ed9d Compare March 26, 2019 13:16
@xeroc xeroc force-pushed the feature/manager-for-sports-and-underlying branch from 7a3ed9d to ab4749d Compare March 26, 2019 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants