Improve module tests #1945
Open
Improve module tests #1945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set module shutdown timeout to default value used across the project. It means to 60 seconds. This value is defined in ModulesConfig class. By this change we are going to avoid random timeouts observed during verify jobs. JIRA: LIGHTY-299 Signed-off-by: Ivan Hrasko <[email protected]>
Remove sleeping from tests. Instead use dedicated shutdown methods which are designed to accept timeouts. JIRA: LIGHTY-299 Signed-off-by: Ivan Hrasko <[email protected]>
ihrasko
force-pushed
the
improve-module-tests
branch
from
5d7ed5b
to
6d3c1ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.