Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024-03 Calcium integration #1813

Merged
merged 70 commits into from
Apr 24, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
70 commits
Select commit Hold shift + click to select a range
74daad3
Bump ODL versions to calcium
Tobianas Feb 2, 2024
82766c7
Rename singleton service components
Tobianas Feb 2, 2024
bf7523f
Do not use ClusterAdminService
Tobianas Apr 9, 2024
50ef960
Remove usage of methods which are no longer visible
Tobianas Feb 12, 2024
d722b5b
Clean up XmlElement methods
Tobianas Apr 9, 2024
b60b1e4
NodeBuilders
Tobianas Apr 9, 2024
b4c79c5
Changed $Yang* generation package and name
Tobianas Feb 15, 2024
a970d6a
Refactor DOMNotificationSubscriptionListener(Registry)
Tobianas Apr 9, 2024
53b8739
Remove EffectiveModelContext{Listener,Provider}
Tobianas Feb 15, 2024
1f694a7
Refactor DOMYangTextSourceProvider
Tobianas Feb 15, 2024
f4a5fa2
Do not use ClusterAdminService
Tobianas Feb 15, 2024
0536e4b
Rename singleton service components
Tobianas Feb 15, 2024
59e4a4e
Remove odl-controller-exp-netty-config
Tobianas Feb 15, 2024
1add9e9
Do not use DOMClusterSingletonServiceProviderImpl
Tobianas Feb 16, 2024
066b393
Adopt DOMNotificationRouter initialization changes
Tobianas Feb 16, 2024
7d6d087
Reduce ObjectRegistration use
Tobianas Feb 16, 2024
201cade
Adopt changes from ModuleInfoSnapshot
Tobianas Feb 16, 2024
3379fce
Rename DOMRpcRouterServices methods
Tobianas Feb 16, 2024
b84e8e1
Remove support for composite NotificationListener
Tobianas Feb 16, 2024
98ed609
Throw ExecutionException to close ClusterSingletonServiceProvider
Tobianas Feb 16, 2024
b3dd9e1
Remove SchemaContextHandler
Tobianas Feb 16, 2024
382235b
Do not use RestconfStreamsConstants
Tobianas Feb 16, 2024
6df1fe2
Inline RestconfApplication
Tobianas Feb 20, 2024
bfec31f
Remove WebSocketInitializer
Tobianas Feb 21, 2024
e4539c1
Use newer revision of distributed-datastore-provider
Tobianas Feb 21, 2024
44b9746
Remove ask-based protocol client
Tobianas Feb 21, 2024
d895b22
Make DataTreeChangeListener implementations use list
Tobianas Feb 21, 2024
bd95b40
Do not encrypt/decrypt strings
Tobianas Feb 21, 2024
c30f651
Remove obsolete NetconfClientDispatcher
Tobianas Feb 21, 2024
348a5e4
Rework BaseScheams
Tobianas Feb 21, 2024
b7c7d10
Rework NetconfTopology initialization
Tobianas Feb 21, 2024
de6c73f
Rename DOMActionServiceExtension to DOMActionService.Extension
Tobianas Feb 22, 2024
c2f5077
Get NetconfMessage from netconf.api.messages
Tobianas Feb 22, 2024
abd426c
Remove redundant getExtensions method
Tobianas Feb 22, 2024
947e381
Use newer revision of netconf-node-topology
Tobianas Feb 22, 2024
c23e0b7
Clean up netconf-{common,client}-mdsal constants
Tobianas Feb 26, 2024
16f1f7c
Disconnect NormalizedNode from Identifiable
Tobianas Feb 26, 2024
91ff56d
Use newer revision of odl-netconf-callhome-server
Tobianas Feb 26, 2024
3862956
Remove RootResourceDiscoveryService
Tobianas Feb 26, 2024
dcc5c45
Use newer revision of sal-remote-augment
Tobianas Feb 26, 2024
b617e98
Use newer revision of odl-device-notification
Tobianas Feb 26, 2024
17ea33b
Introduce restconf.server.{api,spi,mdsal}
Tobianas Feb 26, 2024
4bebed7
Eliminate InstanceIdentifierContext
Tobianas Feb 26, 2024
2603892
Eliminate PatchDataTransactionUtil
Tobianas Feb 27, 2024
f85da49
Eliminate PatchEditOperation
Tobianas Feb 27, 2024
d1d44da
Eliminate OpenApiApplication class
Tobianas Feb 27, 2024
ab2da62
Add missing OpenApiService exceptions
Tobianas Feb 27, 2024
52965ed
Use DelegatedYangTextSource
Tobianas Feb 27, 2024
f533c2d
Use FileYangTextSource
Tobianas Feb 27, 2024
64d9d45
Use SourceIdentifier as CharSource
Tobianas Feb 28, 2024
4850f7b
Rename YangIRSource method
Tobianas Feb 28, 2024
cd80bc2
Eliminate YangModelDependencyInfo
Tobianas Feb 28, 2024
bfaa3d5
Remove usage of aaa.encrypt.PKIUtil
Tobianas Feb 28, 2024
4c7badf
Remove (DOM)TransactionChainListener
Tobianas Mar 4, 2024
b52e5cc
Refactor PathArgument to DataObjectStep
Tobianas Mar 4, 2024
d576451
Remove yang.binding.RpcService
Tobianas Mar 5, 2024
fe08b97
Expose completion future from WriteOperations
Tobianas Mar 5, 2024
0a73bbd
Throw exception if decryption/encryption fails
Tobianas Mar 5, 2024
aba4f7e
Disconnect bgp from global event loop groups
Tobianas Mar 6, 2024
59ff909
Use newer revision of odl-netconf-device
Tobianas Mar 6, 2024
ccade21
Change Credentials creation
Tobianas Mar 6, 2024
2399d3b
Factor out MdsalDatabindProvider
Tobianas Apr 9, 2024
5ef3499
Provide yanglib-mdsal-writer to Lighty controller
Tobianas Apr 9, 2024
f7c9189
Change action output
Tobianas Apr 9, 2024
fb343f7
Create workaround for NETCONF-1285
Tobianas Apr 9, 2024
f922927
Do not hard-code localhost
Tobianas Apr 9, 2024
c2d4797
Adjust expected test result
Tobianas Apr 9, 2024
b3e80d2
Use newer revision of netconf-keystore
Tobianas Apr 9, 2024
d3c391d
Use newer revision of netconf-node-topology/optional
Tobianas Apr 9, 2024
b5da251
Adjust expected message response
Tobianas Apr 10, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ private void parseToResult(final NormalizedNodeStreamWriter writer, final Reader

@Override
public EffectiveModelContext getModelContext() {
return jsonCodecFactory.getEffectiveModelContext();
return jsonCodecFactory.modelContext();
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ public abstract class AbstractCodecTest {

public AbstractCodecTest() throws YangParserException {
this.bindingCodecContext = createCodecContext(loadModuleInfos());
this.effectiveModelContext = bindingCodecContext.getRuntimeContext().getEffectiveModelContext();
this.effectiveModelContext = bindingCodecContext.getRuntimeContext().modelContext();

this.toasterTopLevelContainerNode = topLevelContainerNode();
this.rpcLeafInputNode = rpcLeafInputNode();
Expand All @@ -93,7 +93,7 @@ private static BindingCodecContext createCodecContext(final List<YangModuleInfo>
defaultYangParserFactory);
moduleInfoSnapshotBuilder.add(moduleInfos);
final BindingRuntimeTypes bindingRuntimeTypes = bindingRuntimeGenerator
.generateTypeMapping(moduleInfoSnapshotBuilder.build().getEffectiveModelContext());
.generateTypeMapping(moduleInfoSnapshotBuilder.build().modelContext());

final DefaultBindingRuntimeContext defaultBindingRuntimeContext = new DefaultBindingRuntimeContext(
bindingRuntimeTypes, moduleInfoSnapshotBuilder.build());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
import org.opendaylight.mdsal.eos.dom.api.DOMEntityOwnershipService;
import org.opendaylight.mdsal.singleton.common.api.ClusterSingletonServiceProvider;
import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.md.sal.cluster.admin.rev151013.ClusterAdminService;
import org.opendaylight.yangtools.yang.model.api.EffectiveModelContextProvider;
import org.opendaylight.yangtools.yang.model.api.EffectiveModelContext;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

Expand All @@ -66,7 +66,7 @@ protected void configure() {
.toInstance(lightyServices.getDiagStatusService());
bind(ActorSystemProvider.class)
.toInstance(lightyServices.getActorSystemProvider());
bind(EffectiveModelContextProvider.class).toInstance(lightyServices.getEffectiveModelContextProvider());
bind(EffectiveModelContext.class).toInstance(lightyServices.getEffectiveModelContext());
ihrasko marked this conversation as resolved.
Show resolved Hide resolved
bind(DOMSchemaService.class)
.toInstance(lightyServices.getDOMSchemaService());
bind(DOMYangTextSourceProvider.class)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public void testDIActorSystemProvider() {

@Test
public void testDISchemaContextProvider() {
assertNotNull(testService.getSchemaContextProvider());
assertNotNull(testService.getSchemaContext());
}

@Test
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
import org.opendaylight.mdsal.eos.dom.api.DOMEntityOwnershipService;
import org.opendaylight.mdsal.singleton.common.api.ClusterSingletonServiceProvider;
import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.md.sal.cluster.admin.rev151013.ClusterAdminService;
import org.opendaylight.yangtools.yang.model.api.EffectiveModelContextProvider;
import org.opendaylight.yangtools.yang.model.api.EffectiveModelContext;

public class TestService {

Expand All @@ -50,7 +50,7 @@ public class TestService {
private ActorSystemProvider actorSystemProvider;

@Inject
private EffectiveModelContextProvider effectiveModelContextProvider;
private EffectiveModelContext effectiveModelContext;

@Inject
private DOMSchemaService domSchemaService;
Expand Down Expand Up @@ -156,8 +156,8 @@ public ActorSystemProvider getActorSystemProvider() {
return actorSystemProvider;
}

public EffectiveModelContextProvider getSchemaContextProvider() {
return effectiveModelContextProvider;
public EffectiveModelContext getSchemaContext() {
ihrasko marked this conversation as resolved.
Show resolved Hide resolved
return effectiveModelContext;
}

public DOMSchemaService getDomSchemaService() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
import org.opendaylight.mdsal.eos.dom.api.DOMEntityOwnershipService;
import org.opendaylight.mdsal.singleton.common.api.ClusterSingletonServiceProvider;
import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.md.sal.cluster.admin.rev151013.ClusterAdminService;
import org.opendaylight.yangtools.yang.model.api.EffectiveModelContextProvider;
import org.opendaylight.yangtools.yang.model.api.EffectiveModelContext;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.context.annotation.Bean;
Expand Down Expand Up @@ -141,8 +141,8 @@ public ActorSystemProvider actorSystemProvider() {
}

@Bean(destroyMethod = "")
public EffectiveModelContextProvider effectiveModelContextProvider() {
return this.lightyController.getServices().getEffectiveModelContextProvider();
public EffectiveModelContext effectiveModelContext() {
return this.lightyController.getServices().getEffectiveModelContext();
}

@Bean(destroyMethod = "")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
import org.opendaylight.mdsal.eos.dom.api.DOMEntityOwnershipService;
import org.opendaylight.mdsal.singleton.common.api.ClusterSingletonServiceProvider;
import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.md.sal.cluster.admin.rev151013.ClusterAdminService;
import org.opendaylight.yangtools.yang.model.api.EffectiveModelContextProvider;
import org.opendaylight.yangtools.yang.model.api.EffectiveModelContext;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.beans.factory.annotation.Autowired;
Expand Down Expand Up @@ -81,7 +81,7 @@ public class LightyCoreSpringConfigurationTest extends AbstractJUnit4SpringConte
ActorSystemProvider actorSystemProviderTestProperty;

@Autowired
EffectiveModelContextProvider effectiveModelContextProvider;
EffectiveModelContext effectiveModelContext;

@Autowired
DOMSchemaService domSchemaServiceTestProperty;
Expand Down Expand Up @@ -177,7 +177,7 @@ public void testLightyBeansExists() {
assertNotNull(lightyModuleRegistryServiceTestProperty);
assertNotNull(diagStatusServiceTestProperty);
assertNotNull(actorSystemProviderTestProperty);
assertNotNull(effectiveModelContextProvider);
assertNotNull(effectiveModelContext);
assertNotNull(domSchemaServiceTestProperty);
assertNotNull(domYangTextSourceProviderTestProperty);
assertNotNull(domMountPointServiceTestProperty);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
import org.opendaylight.mdsal.eos.dom.api.DOMEntityOwnershipService;
import org.opendaylight.mdsal.singleton.common.api.ClusterSingletonServiceProvider;
import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.md.sal.cluster.admin.rev151013.ClusterAdminService;
import org.opendaylight.yangtools.yang.model.api.EffectiveModelContextProvider;
import org.opendaylight.yangtools.yang.model.api.EffectiveModelContext;
import org.opendaylight.yangtools.yang.parser.api.YangParserFactory;

/**
Expand All @@ -62,7 +62,7 @@ public interface LightyServices extends LightyModuleRegistryService {

ActorSystemProvider getActorSystemProvider();

EffectiveModelContextProvider getEffectiveModelContextProvider();
EffectiveModelContext getEffectiveModelContext();
ihrasko marked this conversation as resolved.
Show resolved Hide resolved

DOMSchemaService getDOMSchemaService();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@
import org.opendaylight.yangtools.util.DurationStatisticsTracker;
import org.opendaylight.yangtools.util.concurrent.SpecialExecutors;
import org.opendaylight.yangtools.yang.binding.YangModuleInfo;
import org.opendaylight.yangtools.yang.model.api.EffectiveModelContextProvider;
import org.opendaylight.yangtools.yang.model.api.EffectiveModelContext;
import org.opendaylight.yangtools.yang.parser.api.YangParserFactory;
import org.opendaylight.yangtools.yang.parser.impl.DefaultYangParserFactory;
import org.opendaylight.yangtools.yang.xpath.api.YangXPathParserFactory;
Expand Down Expand Up @@ -357,8 +357,7 @@ protected boolean initProcedure() {
final InitialConfigData initialData = this.initialConfigData.get();
try (InputStream inputStream = initialData.getAsInputStream()) {
FileToDatastoreUtils.importConfigDataFile(inputStream, initialData.getFormat(),
getEffectiveModelContextProvider().getEffectiveModelContext(),
this.getClusteredDOMDataBroker(), true);
getEffectiveModelContext(), this.getClusteredDOMDataBroker(), true);
} catch (TimeoutException | ExecutionException | IOException | DeserializationException e) {
LOG.error("Exception occurred while importing config data from file", e);
return false;
Expand Down Expand Up @@ -504,8 +503,8 @@ public ActorSystemProvider getActorSystemProvider() {
}

@Override
public EffectiveModelContextProvider getEffectiveModelContextProvider() {
return this.moduleInfoSnapshot;
public EffectiveModelContext getEffectiveModelContext() {
return this.moduleInfoSnapshot.modelContext();
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public void controllerSimpleTest() {
lightyController.getServices().getDiagStatusService().getAllServiceDescriptors());
Assert.assertNotNull(lightyController.getServices().getActorSystemProvider());
Assert.assertNotNull(lightyController.getServices().getActorSystemProvider().getActorSystem());
Assert.assertNotNull(lightyController.getServices().getEffectiveModelContextProvider());
Assert.assertNotNull(lightyController.getServices().getEffectiveModelContext());
Assert.assertNotNull(lightyController.getServices().getDOMSchemaService());
Assert.assertNotNull(lightyController.getServices().getDOMYangTextSourceProvider());
Assert.assertNotNull(lightyController.getServices().getDOMNotificationRouter());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ private void importFile(final String path, final YangInstanceIdentifier yii, fin
FileToDatastoreUtils.importConfigDataFile(FileToDatastoreUtils.class.getResourceAsStream(path),
yii,
format,
lightyController.getServices().getEffectiveModelContextProvider().getEffectiveModelContext(),
lightyController.getServices().getEffectiveModelContext(),
lightyController.getServices().getClusteredDOMDataBroker(),
true);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ public BgpModule(final EffectiveModelContext modelContext, final DataBroker data
}

public BgpModule(final LightyServices lightyServices) {
this(lightyServices.getEffectiveModelContextProvider().getEffectiveModelContext(),
this(lightyServices.getEffectiveModelContext(),
lightyServices.getBindingDataBroker(), lightyServices.getClusteredDOMDataBroker(),
lightyServices.getBindingCodecTreeFactory(),
lightyServices.getAdapterContext().currentSerializer().getRuntimeContext(),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ Write result into container builder with identifier (netconf:base)data. Makes po

final NormalizedNodeStreamWriter streamWriter = ImmutableNormalizedNodeStreamWriter.from(resultBuilder);
final JSONCodecFactory jsonCodecFactory =
JSONCodecFactorySupplier.RFC7951.createLazy(inference.getEffectiveModelContext());
JSONCodecFactorySupplier.RFC7951.createLazy(inference.modelContext());

try (JsonParserStream jsonParser = JsonParserStream.create(streamWriter,
jsonCodecFactory, inference)) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@ public void loadTopLevelSingleNodeModelsFromJsonConfig() throws Exception {
final LightyController lightyController = getLightyController("sampleConfigSingleNode.json");
assertTrue(lightyController.start().get(TIME_OUT, TimeUnit.SECONDS));

final int loadedModulesSize = lightyController.getServices().getEffectiveModelContextProvider()
.getEffectiveModelContext().getModules().size();
final int loadedModulesSize = lightyController.getServices().getEffectiveModelContext().getModules().size();
assertTrue(lightyController.shutdown(TIME_OUT, TimeUnit.SECONDS));

assertEquals(loadedModulesSize, 17);
Expand All @@ -41,8 +40,7 @@ public void loadTopLevelClusterModelsFromJsonConfig() throws Exception {
final LightyController lightyController = getLightyController("sampleConfigCluster.json");
assertTrue(lightyController.start().get(TIME_OUT, TimeUnit.SECONDS));

final int loadedModulesSize = lightyController.getServices().getEffectiveModelContextProvider()
.getEffectiveModelContext().getModules().size();
final int loadedModulesSize = lightyController.getServices().getEffectiveModelContext().getModules().size();
assertTrue(lightyController.shutdown(TIME_OUT, TimeUnit.SECONDS));

assertEquals(loadedModulesSize, 17);
Expand Down