Add max_failed_iter option to steadystate_ptc solvers #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default value max_failed_iter=20 Added to implicit-Euler solvers (usually used for PTC to steady-state): - steadystate_ptc, steadystate_ptcForwardDiff - steadystate_ptc_splitdae Exit after max_failed_iter iterations that make no progress (either due to a failed iteration, or to an iteration that didn't change the solution ie already within tolerance) This forces an exit when a solution reaches the convergence limit of the solver (typically cycles through a repeating sequence of increasing and then decreasing timesteps, from iterations that don't change solution and iterations that fail to converge)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default value max_failed_iter=20
Added to implicit-Euler solvers (usually used for PTC to steady-state):
Exit after max_failed_iter iterations that make no progress (either due to a failed iteration, or to an iteration that didn't change the solution ie already within tolerance)
This forces an exit when a solution reaches the convergence limit of the solver (typically cycles through a repeating sequence of increasing and then decreasing timesteps, from iterations that don't change solution and iterations that fail to converge)