VariableAggregator test pack CellSpace variables #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test code - not complete VariableAggregator can optionally add `packed_vars` which should be CellSpace variables from a single Domain with cells defined by `packed_cellranges`
sjdaines
added a commit
to PALEOtoolkit/PALEOmodel.jl
that referenced
this pull request
Jul 25, 2023
Requires PALEOtoolkit/PALEOboxes.jl#94 Test code for packing CellSpace Variables, to evaluate whether this improves solver performance for atmosphere models. PALEOmodel.initialize!(model; pack_domain="atm") will reorder CellSpace Variables in "atm" Domain by cell (so all variables for a cell are adjacent in the aggregated stateexplicit and sms vectors) Tested with steadystate_ptcForwardDiff solver (NB: steadystate_ptc_splitdae does not work !) Shows neglible difference with minimal CHO and CHONS models, which suggests that the default reordering by UMFPACK (Julia \ for sparse matrices) already does a good job of finding a permutation that puts the Jacobian in block-diagonal form (?).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test code - not complete
VariableAggregator can optionally add
packed_varswhich should be CellSpace variables from a single Domain with cells defined bypacked_cellranges