Add optional check that units for linked variables match #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 'allocate_variables!' add 'check_units_opt' keyword, with allowed values:
:no - (default) no check
:warn - check that units for linked variables match (ie all variables linked together have the same units)
:error - check and error if mismatch found
- units="unknown" is a magic value that means 'don't check this variable', units="" is convention for
dimensionless value.
- fix some bugs where units were missing
- set units="unknown" for generic reactions (eg ReactionForceGrid) where the units are not known.
NB: units attribute can be set in the yaml file if needed, to reenable checks.
sjdaines
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'allocate_variables!' add 'check_units_opt' keyword, with allowed values: :no - (default) no check :warn - check that units for linked variables match (ie all variables linked together have the same units) :error - check and error if mismatch found
units="unknown" is a magic value that means 'don't check this variable', units="" is convention for dimensionless value.
fix some bugs where units were missing
set units="unknown" for generic reactions (eg ReactionForceGrid) where the units are not known. NB: units attribute can be set in the yaml file if needed, to reenable checks.