Refill crafting grid functionality from PR #73 brought up to date #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting with a Crafting Upgrade
…ervers/SophisticatedCore into 1.18.x of https://github.com/FrizMods/SophisticatedStorage # Conflicts resolved: # src/main/java/net/p3pp3rf1y/sophisticatedcore/common/gui/StorageContainerMenuBase.java # src/main/resources/assets/sophisticatedcore/textures/gui/icons.png
-creating new button icons for the refill crafting grid functionality(were in last commit, removing the unused icon) -adding the ability for the refill crafting grid to pull from the player inventory as well
|
@P3pp3rF1y can you confirm this is what you want, I'm not sure if you like the icons for the buttons as I did them or if it is better to use the other refill icon that already exists along with the red cross-out circle for off |
…kit on a iron pick axe to consume a diamond pick axe because the InventoryHelper does not check tags when using extractFromInventory(Item item, int count, IItemHandler inventory, boolean simulate), this is fine for its original use in the compacting upgrade, but here we need somthing that uses the isSameItemSameTag function from the ItemStack class. -added functions similar to what is in the Inventory class of minecraft for this purpose of finding the slot index using the isSameItemSameTags function and then extracting/removing the item from the slot index like what is done on the player inventory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dependant pr's:
P3pp3rF1y/SophisticatedBackpacks#1069
P3pp3rF1y/SophisticatedStorage#430