Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor wear time and coverage logic; new fields WearStartTime and WearEndTime; set first/last days to NA instead of dropping #134

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

chanshing
Copy link
Member

@chanshing chanshing commented Oct 17, 2024

  • Reverted dropping first and last days from the series - instead set them to NA
  • Refactored wear time stats and coverage logic into a new function: summarize_wear_time.
  • Added WearStartTime and WearEndTime fields to indicate start and end of actual wear.

@chanshing chanshing changed the title refactor: improve wear time stats and coverage calculation logic refactor: improve wear time stats and coverage calculation logic; new fields WearStartTime and WearEndTime Oct 17, 2024
@chanshing chanshing changed the title refactor: improve wear time stats and coverage calculation logic; new fields WearStartTime and WearEndTime Improve wear time stats and coverage calculation logic; new fields WearStartTime and WearEndTime; set first/last days to NA instead of dropping Oct 17, 2024
@chanshing chanshing changed the title Improve wear time stats and coverage calculation logic; new fields WearStartTime and WearEndTime; set first/last days to NA instead of dropping Refactor wear time and coverage logic; new fields WearStartTime and WearEndTime; set first/last days to NA instead of dropping Oct 17, 2024
…e and coverage logic

- Refactored wear time stats and coverage logic into a new function: summarize_wear_time.
- Added WearStartTime and WearEndTime fields to indicate start and end of actual wear.
@chanshing chanshing merged commit 5641d82 into main Oct 17, 2024
9 checks passed
@chanshing chanshing deleted the fix-exclude-days branch October 17, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant