add UnsubscribeURL to SNS notification message (localstack#2467)

OwnZones · May 28, 2020 · 1a184c0 · 1a184c0
1 parent 6dcffb3
commit 1a184c0
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/localstack/services/awslambda/lambda_api.py b/localstack/services/awslambda/lambda_api.py
@@ -261,18 +261,26 @@ def process_apigateway_invocation(func_arn, path, payload, headers={},
         LOG.warning('Unable to run Lambda function on API Gateway message: %s %s' % (e, traceback.format_exc()))
 
 
-def process_sns_notification(func_arn, topic_arn, subscription_arn, message, message_attributes, subject='',):
+def process_sns_notification(func_arn, topic_arn, subscription_arn, message,
+        message_attributes, unsubscribe_url, subject='',):
     event = {
         'Records': [{
             'EventSource': 'localstack:sns',
             'EventVersion': '1.0',
             'EventSubscriptionArn': subscription_arn,
             'Sns': {
                 'Type': 'Notification',
+                'MessageId': str(uuid.uuid4()),
                 'TopicArn': topic_arn,
                 'Subject': subject,
                 'Message': message,
                 'Timestamp': timestamp_millis(),
+                'SignatureVersion': '1',
+                # TODO Add a more sophisticated solution with an actual signature
+                # Hardcoded
+                'Signature': 'EXAMPLEpH+..',
+                'SigningCertUrl': 'https://sns.us-east-1.amazonaws.com/SimpleNotificationService-000000000.pem',
+                'UnsubscribeUrl': unsubscribe_url,
                 'MessageAttributes': message_attributes
             }
         }]

diff --git a/localstack/services/sns/sns_listener.py b/localstack/services/sns/sns_listener.py
@@ -265,12 +265,16 @@ def publish_message(topic_arn, req_data, subscription_arn=None):
 
         elif subscriber['Protocol'] == 'lambda':
             try:
+                external_url = external_service_url('sns')
+                unsubscribe_url = '%s/?Action=Unsubscribe&SubscriptionArn=%s' % (external_url,
+                                    subscriber['SubscriptionArn'])
                 response = lambda_api.process_sns_notification(
                     subscriber['Endpoint'],
                     topic_arn,
                     subscriber['SubscriptionArn'],
                     message,
                     message_attributes,
+                    unsubscribe_url,
                     subject=req_data.get('Subject', [None])[0]
                 )
                 if isinstance(response, FlaskResponse):