Removed logging when objects are constructed and destructed #19
Conversation
permobergedge
force-pushed
the
per/remove_construct_destruct_logging_change_to_c++_casting
branch
2 times, most recently
from
6811413 to
957a072
Compare
| #define EFP_MAJOR_VERSION 0 | ||
| #define EFP_MINOR_VERSION 4 | ||
| constexpr uint8_t EFP_MAJOR_VERSION = 0; | ||
| constexpr uint8_t EFP_MINOR_VERSION = 4; |
There was a problem hiding this comment.
Should we increase version, just for the record? After all, you have made some changes, most of them (hopefully) not noticeable, except for the removed loggings.
There was a problem hiding this comment.
This PR should not have changed the behavior of the repo, not even fixed any bugs, so I would argue this would not bump the version number. This PR ought to just be a refactorization of the code style.
And the logs should not have been used for anything except manual debugging, so no need to bump the version because of them, if you ask me.
ElasticFrameProtocol.cpp
Outdated
| @@ -14,7 +14,7 @@ | |||
| #include "ElasticInternal.h" | |||
| #include "logger.h" | |||
|
|
|||
| #define WORKER_THREAD_SLEEP_US 1000 * 10 | |||
| #define WORKER_THREAD_SLEEP_US (1000 * 10) | |||
There was a problem hiding this comment.
Change to constexpr uint32_t or something similar?
| #define EFP_MAJOR_VERSION 0 | ||
| #define EFP_MINOR_VERSION 4 | ||
| constexpr uint8_t EFP_MAJOR_VERSION = 0; | ||
| constexpr uint8_t EFP_MINOR_VERSION = 4; |
There was a problem hiding this comment.
This PR should not have changed the behavior of the repo, not even fixed any bugs, so I would argue this would not bump the version number. This PR ought to just be a refactorization of the code style.
And the logs should not have been used for anything except manual debugging, so no need to bump the version because of them, if you ask me.
Changed from c-style casting to c++-style.
permobergedge
force-pushed
the
per/remove_construct_destruct_logging_change_to_c++_casting
branch
from
957a072 to
b01c78c
Compare
Changed from c-style casting to c++-style.