Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find WeakResourceLinks and add a right-click menu for them #29

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

factubsio
Copy link

Also show an error dialog on the right click commands if the blueprint/asset can't be found

@factubsio
Copy link
Author

For issue #27

@factubsio factubsio changed the title Find WeakAssetLinks and add a right-click menu for them Find WeakResourceLinks and add a right-click menu for them Dec 21, 2021
@BurlyWurly
Copy link

The new functionality on right click appears to be added (I'm assuming it's the 'copy AssetID') but assets still aren't being imported.

@factubsio
Copy link
Author

Can I see your jbp/patch file please?

@BurlyWurly
Copy link

I made sure to keep it as foolproof as possible on the patch end for the test run. It's just a basic patch of Irabeth's portrait.

{
    "Data": {
      "m_PortraitImage": {
        "AssetId": "744eda9e1fc78e34c8cecbfb7ffdf6d8"
      },
      "m_HalfLengthImage": {
        "AssetId": "fa1074ebd3eacdd43ad639c9bff175a3"
      },
      "m_FullLengthImage": {
        "AssetId": "285f2ea43cc32a64492251e4caa1b5a8"
      }
    }
}

Patch works and is trying to apply - it breaks her portrait. There's simply a white space because presumably the patched AssetIds point to an asset that isn't being imported.

@factubsio
Copy link
Author

Sorry can you show me a screenshot of your Content folder (where the sprites are)?

@BurlyWurly
Copy link

Screenshot (167)
Small portrait selected in this.

@factubsio
Copy link
Author

Thanks will try to repro locally

@factubsio
Copy link
Author

@BurlyWurly this should work now.

Note: you need at least one script + asmdef, (the script can be empty), otherwise the mod will partially fail when loading and not correctly register its own bundles.

@BurlyWurly
Copy link

That seems to have done it, great work and thank you! They should probably amend the initial template setup to include setting up a placeholder script, as right now it just has you put in an asmdef.

@factubsio
Copy link
Author

@hmmvot any chance of taking a look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants