RMET-3608 OneSignal-Cordova-SDK - Update dependency to FCM Android SDK #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: According to the documentation, this is the recommended way of controlling Firebase library versions. This way, using the Firebase Android BOM, an app with multiple Firebase Android libraries will always use compatible versions of these libraries. References: https://outsystemsrd.atlassian.net/browse/RMET-3608
This reverts commit a3e6be3.
alexgerardojacinto
changed the title
|
alexgerardojacinto
changed the title
alexgerardojacinto
requested review from
ItsChaceD,
IT-MikeS,
OS-ricardomoreirasilva and
OS-martacarlos
and removed request for
a team
IT-MikeS
approved these changes
Sep 13, 2024
ItsChaceD
approved these changes
Sep 13, 2024
alexgerardojacinto
added a commit
that referenced
this pull request
Sep 17, 2024
* RMET-3477 :: OutSystems Wrapper :: Add OneSignal Plugin Manager (#35) - adds code specific to outsystems lifecycle aka one signal plugin manager - adds the code that will be in outsystems wrapper's javascript nodes - add sonar cloud integration for typescript files https://outsystemsrd.atlassian.net/browse/RMET-3477 * RMET-3608 OneSignal-Cordova-SDK - Update dependency to FCM Android SDK (#36) * feat: update FB Messaging Android library References: https://outsystemsrd.atlassian.net/browse/RMET-3608 * feat: use Firebase BOM to get FB Cloud Messaging lib Context: According to the documentation, this is the recommended way of controlling Firebase library versions. This way, using the Firebase Android BOM, an app with multiple Firebase Android libraries will always use compatible versions of these libraries. References: https://outsystemsrd.atlassian.net/browse/RMET-3608 * Revert "feat: use Firebase BOM to get FB Cloud Messaging lib" This reverts commit a3e6be3. * fix: add necessary Firebase library for OneSignal to work with latest version of Cloud Messaging Context: https://firebase.google.com/support/release-notes/android?_gl=1*d5zec9*_up*MQ..*_ga*OTY5NjA2OTg5LjE3MjYwNTUwMDE.*_ga_CW55HF8NVT*MTcyNjA1NTAwMS4xLjAuMTcyNjA1NTAwMS4wLjAuMA..#messaging_v22-0-0 References: https://outsystemsrd.atlassian.net/browse/RMET-3608 * chore: update changelog References: https://outsystemsrd.atlassian.net/browse/RMET-3608 * chore(release): raise to version 2.11.1-OS12 References: https://outsystemsrd.atlassian.net/browse/RMET-3608 --------- Co-authored-by: Marta Carlos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
com.google.firebase:firebase-iidto maintain compatibility, because this used to be included incom.google.firebase:firebase-messagingby default, but not anymore. More info here: https://firebase.google.com/support/release-notes/android#messaging_v22-0-0Context
References: https://outsystemsrd.atlassian.net/browse/RMET-3608
Type of changes
Platforms affected
Tests
Tested on MABS 10 and MABS 9 builds, on Android 15 (Pixel 7) and Android 12 (Pixel 3XL)
MABS 10 build: https://intranet.outsystems.net/MABS/BuildDetail.aspx?BuildId=fd0ea20cd07d6c5b8690bdbccb6401426bfaf3dc
Nativizer build with all supported plugins (including Firebase plugins + OneSignal): https://intranet.outsystems.net/MABS/BuildDetail.aspx?BuildId=41229af81be7c243397b3c20cb8fd5d5364dbd85
Screenshots (if appropriate)
Checklist
RNMT-XXXX <title>