Glob-like patterns in AttrFormatter and french nouns #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlogan2000
requested changes
Sep 15, 2020
aulemahal
changed the title
|
The doctests are failing on the style of guillemets. That's annoying. Looking into this. |
|
Opened an issue about it. You may need to change your string quotations in the meantime. Erotemic/xdoctest#87 |
|
Oh easy fix. I will use «» instead. |
|
Sooo, the first doctest uses " and the second one ' ? Some magic is happening here... |
|
The maintainer of xdoctest is open to a PR to implement a means to relax this feature, but this wacky behaviour exists in the stdlib doctest as well. He mentioned using |
…lim into locales-glob-modif-frnouns
Pull Request Test Coverage Report for Build 2317
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 2317
💛 - Coveralls |
tlogan2000
approved these changes
Sep 15, 2020
|
The stalled and failed RTD build is not updating here in github? Anyway, I tested this branch on RTD directly and it worked. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
bumpversion (minor / major / patch)has been called on this branchgit push --tags)What kind of change does this PR introduce?
Values to format, in
core.formatting.AttrFormattercan now include glob-like patterns. Example :"QS-*" that translates to "seasonal".Does this PR introduce a breaking change?
No
Other information:
Also added the plural nouns in french. I don't think we're using them, but they exist in the english formatter.