-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small clean up of dependencies and environment #1381
Conversation
I just landed on this post thinking, "will this work, maybe?" tox-dev/sphinx-autodoc-typehints#186 (comment) It was me. I wrote the post. ... |
86610c9
to
e31ae6b
Compare
960cb7d
to
f3e9447
Compare
Theory: My workaround to deal with the fact that we can't supply There's a possibility that this could be fixed with the latest sphinx/sphinx-autodoc-typehints, but we can't install it due to limitations with sphinx_rtd_theme (it's effectively unmaintained). Changing to a different theme (like Furo, used in Miranda) involves some changes to our sphinx configuration, but maybe it would be worthwhile investigating soon? This merits its own issue, tbh. In any case, problems resolved. It had nothing to do with the pylint pin. |
Update: The warnings appear to be due to an |
All this needs is an entry under |
Pull Request Checklist:
number
) and pull request (:pull:number
) has been addedWhat kind of change does this PR introduce?
clisops
from theenvironment.yml
, which removes the indirect dev dependency toxESMF
.filelock
, without listing it in the env (it's a dep oftox
).statsmodels
was in the "dev" deps section, but is a hard dep.pylint
was blocking the creation of an env with python 3.11. I removed it and it seems to work. I modified the rc file slightly to suppress one warning in the output. And, comble de l'ironie, runningpylint
in my older env (python 3.10, pylint 2.14) failed... So I leave the study of why it was pinned and if it is safe to unpin it to @Zeitsperre .Does this PR introduce a breaking change?
No
Other information:
This might be a step towards #1268 !