-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate mf_flag
call signature in xclim.ensembles, expose calendar conversion utilities, fix _gen_returns_section bug
#1317
Conversation
Question: Should I deal with the other API-related comment in this PR?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There are not too many changes here, so from a reviewer pov I would not mind if you also included the other API changes in the same PR.
mf_flag
call signature in xclim.ensemblesmf_flag
call signature in xclim.ensembles, expose calendar conversion utilities
This PR is good for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed!
We had the same Future vs Deprecation issue in xscen this morning...
Co-authored-by: Pascal Bourgault <[email protected]>
c564fcc
to
79c82de
Compare
Way better than before, thanks! |
mf_flag
call signature in xclim.ensembles, expose calendar conversion utilitiesmf_flag
call signature in xclim.ensembles, expose calendar conversion utilities, fix _gen_returns_section bug
Pull Request Checklist:
number
) and pull request (:pull:number
) has been addedWhat kind of change does this PR introduce?
xclim.ensembles.create_ensemble()
and_ens_align_datasets()
to usemultifile
in lieu ofmf_flag
.xclim.indices
into the indices documentation file._gen_returns_section
that caused poor rendering in the documentationDoes this PR introduce a breaking change?
No*. Original calls with kwargs
mf_flag
set will still work, but will emit warnings that users should update their scripts. This will be a major breaking change in xclim v0.43.0. The new functions were previously inaccessible (not breaking).Other information: