Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update portal dependencies November 2024 #357

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

osm-Jatin
Copy link
Contributor

@osm-Jatin osm-Jatin commented Nov 6, 2024

Portal PR Checklist

Pre-requisites

  • I have gone through the Contributing guidelines for Submitting a Pull Request (PR) and ensured that this is not a duplicate PR.
  • I have performed unit testing for the new feature added or updated to ensure the new features addeSd are working as expected.
  • I have performed preliminary testing to ensure that any existing features are not impacted and any new features are working as expected as a whole.

PR Details

PR details have been updated as per the given format (see below)

  • PR title adheres to the format specified in guidelines (e.g., feat: add admin login page)
  • Description has been added
  • Related changes have been added (optional)
  • Screenshots have been added (optional, may include unit testing screenshots as well)
  • Pending actions have been added (optional)
  • Any other additional notes have been added (optional)

Description:

  • Updated package.json and package-lock.json in PORTAL.
  • Didn't update the typescript because it is breaking the code

Related changes:

N/A

Screenshots:

image

Pending actions:

N/A

Additional notes:

N/A

Summary by CodeRabbit

  • Chores
    • Updated various dependencies to their latest versions for improved performance and security, including Angular, Apollo Client, PrimeNG, and ESLint packages.

Copy link

coderabbitai bot commented Nov 6, 2024

Walkthrough

The pull request includes updates to the package.json file of the osmox-portal project, focusing on upgrading several dependencies. Key Angular-related libraries have been updated from version ^18.2.0 to ^18.2.10, alongside updates to @apollo/client, apollo-angular, and other dependencies. This includes both standard and development dependencies, with the overall structure of the package.json remaining unchanged.

Changes

File Change Summary
apps/portal/package.json Updated various dependencies: Angular libraries from ^18.2.0 to ^18.2.10, @apollo/client from ^3.11.2 to ^3.11.8, apollo-angular from ^7.0.2 to ^7.2.1, primeng from ^17.18.6 to ^17.18.11, tslib from ^2.6.3 to ^2.8.1, and various @angular-eslint packages to 18.4.0. Other updates include eslint-plugin-import to ^2.31.0 and jasmine-core to ~5.4.0.

Possibly related PRs

  • chore: update angular dependency version #318: This PR updates various Angular dependencies in the package.json, similar to the main PR which also focuses on upgrading Angular-related dependencies.
  • chore: bump version to 4.0.0 #347: This PR includes updates to the package.json for the portal, specifically mentioning Angular dependencies, which aligns with the main PR's changes to the same file and related dependencies.

Suggested reviewers

  • xixas

Poem

🐇 In the garden of code, we hop and play,
With Angular's updates, we brighten the day.
Dependencies dance, all shiny and new,
In the world of the portal, there's much we can do!
So let’s celebrate with a joyful cheer,
For each little change brings progress near! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@osm-Jatin osm-Jatin self-assigned this Nov 6, 2024
@osm-Jatin osm-Jatin added dependencies Pull requests that update a dependency file ready for review labels Nov 6, 2024
@kshitij-k-osmosys kshitij-k-osmosys requested review from xixas and removed request for osm-vishnukyatannawar and kshitij-k-osmosys November 6, 2024 09:12
@kshitij-k-osmosys kshitij-k-osmosys changed the title fix: update portal dependencies build: update portal dependencies November 2024 Nov 6, 2024
@osm-Jatin osm-Jatin marked this pull request as ready for review November 6, 2024 09:20
@xixas xixas merged commit 3f786a5 into main Nov 20, 2024
6 checks passed
@xixas xixas deleted the fix/update-portal-dependencies branch November 20, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants