Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress exceptions from HubLifetimeManager.Dispose() #157

Open
wants to merge 7 commits into
base: 3.x
Choose a base branch
from

Conversation

JorgeCandeias
Copy link

This PR suppresses exceptions being thrown from OrleansHubLifetimeManager<T> while disposing itself.
It also implements the full async disposable pattern as to be more friendly with the NET6+ Service Provider.

The reason for this PR is that this was causing a red herring for us, by hiding the root cause of another issue that was preventing a silo from starting.

Please note that this PR is based on #156 as we already have that in production. Therefore please address that one first.

Implemented full DisposeAsync pattern.
Refactored.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant