Skip to content

Update Contract-Code-Review.md #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update Contract-Code-Review.md #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions templates/Contract-Code-Review.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ _What is the PR trying to do? Is this the right thing? Are there bugs in the req
#### Proxy

- [ ] No storage variable initialized at definition when contract used as a proxy implementation.
- [ ] Implementation contracts if Governable need to set 0 governor in constructor `_setGovernor(address(0))`

#### Events
- [ ] All state changing functions emit events
Expand Down