Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator balance checks before deposit #2311

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

naddison36
Copy link
Collaborator

@naddison36 naddison36 commented Nov 19, 2024

Changes

  • Added snapValidators Hardhat task
  • Added third staking strategy to Defender Actions
  • Added check that validators do not exist before staking deposit in Defender Action
  • Updated OETH contracts diagram

Code Change Checklist

To be completed before internal review begins:

  • The contract code is complete
  • Executable deployment file
  • Fork tests that test after the deployment file runs
  • Unit tests *if needed
  • The owner has done a full checklist review of the code + tests

Internal review:

  • Two approvals by internal reviewers

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.36%. Comparing base (4f1de43) to head (2d0066d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2311   +/-   ##
=======================================
  Coverage   53.36%   53.36%           
=======================================
  Files          79       79           
  Lines        4098     4098           
  Branches     1079     1079           
=======================================
  Hits         2187     2187           
  Misses       1908     1908           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@naddison36 naddison36 marked this pull request as draft November 19, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant