Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opts for manually choosing container network, port and path #244

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

paulll
Copy link

@paulll paulll commented Mar 16, 2020

No description provided.

@manast
Copy link
Member

manast commented Mar 17, 2020

Could you please explain why you propose this change? thanks.

@paulll
Copy link
Author

paulll commented Mar 18, 2020

Some of my containers have port 22 open, and I haven't found any other way to get redbird to choose another one

@manast
Copy link
Member

manast commented Mar 21, 2020

reason I am not mergin this yet is that I am not sure if this can have consequences for existing users, would be easier if the preferred ports could be passed as an optional parameter.

@paulll paulll force-pushed the docker-port-choosing branch from d2cefd1 to 43a52cb Compare March 29, 2020 22:09
@paulll paulll changed the title prefer http (80 and 8080) ports when choosing the container port opts for manually choosing container network, port and path Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants