Demo of changes that CSharpier makes #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hydrojumbo
reviewed
Jan 13, 2023
Comment on lines
-983
to
-992
| var res = 0 | ||
| + 123 // permitted in C# 1.0 and later | ||
| + 1_2_3 // permitted in C# 7.0 and later | ||
| + 0x1_2_3 // permitted in C# 7.0 and later | ||
| + 0b101 // binary literals added in C# 7.0 | ||
| + 0b1_0_1 // permitted in C# 7.0 and later | ||
|
|
||
| // in C# 7.2, _ is permitted after the `0x` or `0b` | ||
| + 0x_1_2 // permitted in C# 7.2 and later | ||
| + 0b_1_0_1 // permitted in C# 7.2 and later |
There was a problem hiding this comment.
If we realign the comments and then re-run, would we lose the alignment again? Or is this only sensitive to the improper leading whitespace
Comment on lines
+188
to
+190
| var dictionaryInitializer = new Dictionary<int, string> { { 1, "" }, { 2, "a" } }; | ||
| float[] a = new float[] { 0f, 1.1f }; | ||
| int[,,] cube = { | ||
| { { 111, 112 }, { 121, 122 } }, | ||
| { { 211, 212 }, { 221, 222 } } | ||
| }; | ||
| int[,,] cube = { { { 111, 112 }, { 121, 122 } }, { { 211, 212 }, { 221, 222 } } }; |
There was a problem hiding this comment.
Hmm... is this intended to force us to encapsulate object construction? Is there any way to have dictionary initialization span multiple lines?
| ); | ||
| var task = Task.Factory.StartNew(async () => | ||
| { | ||
| return await new WebClient().DownloadStringTaskAsync("http://example.com"); |
There was a problem hiding this comment.
Is it allowed to do:
return await new WebClient()
.DownloadStringTaskAsync("http://example.com");
|
@hydrojumbo : CSharpier is opinionated. The only options are:
So the answer to all of your questions is a very firm: You can't make any changes to the formatting it applies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request merely shows the changes that CSharpier makes to a given piece of code.
For reference: https://github.com/belav/csharpier, and https://github.com/belav/csharpier/blob/master/Src/CSharpier.Tests/Samples/AllInOne.cst