Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nullable? #557

Merged
merged 5 commits into from
Dec 24, 2024
Merged

Fix nullable? #557

merged 5 commits into from
Dec 24, 2024

Conversation

rocktavious
Copy link
Collaborator

Resolves https://github.com/OpsLevel/team-platform/issues/452

Problem

Unable to set the value field to null

Solution

Handle null value properly

Checklist

  • I have run this code, and it appears to resolve the stated issue.
  • This PR does not reduce total test coverage
  • This PR has no user interface changes or has already received approval from product management to change the interface.
  • Make a changie entry that explains the customer facing outcome of this change

@rocktavious rocktavious self-assigned this Dec 24, 2024
davidbloss
davidbloss approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@davidbloss davidbloss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@rocktavious rocktavious merged commit 4269426 into main Dec 24, 2024
7 checks passed
@rocktavious rocktavious deleted the kr/fix-property-value-null branch December 24, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbloss davidbloss davidbloss approved these changes

Assignees

@rocktavious rocktavious

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rocktavious @davidbloss