Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow alias usage for the domain and system owner #555

Merged
merged 6 commits into from
Dec 24, 2024

Conversation

rocktavious
Copy link
Collaborator

Resolves https://github.com/OpsLevel/team-platform/issues/461

Problem

Domain and System owner field cannot properly take a team alias.

Solution

Uses the opslevel-go cache to lookup a team by the alias to find the ID to feed into the mutations.

Checklist

  • I have run this code, and it appears to resolve the stated issue.
  • This PR does not reduce total test coverage
  • This PR has no user interface changes or has already received approval from product management to change the interface.
  • Make a changie entry that explains the customer facing outcome of this change

@rocktavious rocktavious self-assigned this Dec 24, 2024
opslevel/helpers.go Outdated Show resolved Hide resolved
opslevel/provider.go Outdated Show resolved Hide resolved
Copy link
Contributor

@davidbloss davidbloss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@rocktavious rocktavious merged commit ca3afc8 into main Dec 24, 2024
7 checks passed
@rocktavious rocktavious deleted the kr/system-domain-owner-alias branch December 24, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants