add opslevel_service_relationship resource #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rocktavious
reviewed
Dec 23, 2024
| @@ -140,6 +140,14 @@ func getDatasourceFilter(validFieldNames []string) schema.SingleNestedBlock { | |||
| } | |||
| } | |||
|
|
|||
| // Temp wrapper until opslevel-go is updated | |||
rocktavious
reviewed
Dec 23, 2024
| Id: &service.Id, | ||
| Parent: opslevel.NewIdentifier(), | ||
| } | ||
| _, _ = r.client.UpdateService(svcUpdate) |
There was a problem hiding this comment.
shouldn't we handle errors here?
There was a problem hiding this comment.
This is an odd one... Here we know the service exists with the parent matching the state, so if the unsetting the parent fails maybe we just print a TF warning? Throwing an error during delete would be too disruptive.
Also I have TF tests incoming
There was a problem hiding this comment.
Ya lets at least raise a warning if for some reason the removal didn't work - silently swallowing errors that might produce infinite plan applies is worse.
rocktavious
reviewed
Dec 23, 2024
rocktavious
reviewed
Dec 23, 2024
Comment on lines
+153
to
+155
| if err == nil && (service == nil || string(service.Id) == "") { | ||
| err = fmt.Errorf("service %s not found", serviceIdentifier) | ||
| } |
rocktavious
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #469
🎗️ Testing relies on this PR
Problem
Solution
Checklist