Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate Go structs of graphql API objects #499

Merged
merged 5 commits into from
Jan 6, 2025
Merged

generate Go structs of graphql API objects #499

merged 5 commits into from
Jan 6, 2025

Conversation

davidbloss
Copy link
Contributor

@davidbloss davidbloss commented Dec 27, 2024 •
edited
Loading

Resolves #573

Run task gen to see new code generated in object.go

Problem

Solution

Checklist

  • I have run this code, and it appears to resolve the stated issue.
  • This PR does not reduce total test coverage
  • This PR has no user interface changes or has already received approval from product management to change the interface.
  • Does this change require a Terraform schema change?
    • If so what is the ticket or PR #
  • Make a changie entry that explains the customer facing outcome of this change

@davidbloss davidbloss self-assigned this Dec 27, 2024
@davidbloss davidbloss changed the base branch from main to feature/gen-code January 6, 2025 17:43
rocktavious
rocktavious approved these changes Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@rocktavious rocktavious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done this is very clean and easy to review!

@davidbloss davidbloss merged commit 58c303b into feature/gen-code Jan 6, 2025
2 checks passed
@davidbloss davidbloss deleted the db/gen-objects branch January 6, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rocktavious rocktavious rocktavious approved these changes

Assignees

@davidbloss davidbloss

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidbloss @rocktavious