chore(robot-server): Add sqlalchemy2-stubs #9773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyntaxColoring
added
chore
robot-svcs
SyntaxColoring
commented
Mar 24, 2022
Comment on lines
+17
to
+20
| # pytest dependencies on windows, spec'd here to force lockfile inclusion | ||
| # https://github.com/pypa/pipenv/issues/4408#issuecomment-668324177 | ||
| atomicwrites = {version="==1.4.0", sys_platform="== 'win32'"} | ||
| colorama = {version="==0.4.4", sys_platform="== 'win32'"} |
There was a problem hiding this comment.
Moving this section up high because pipenv install --dev foo appends foo to the bottom of the list, which would make it look like foo is part of this Pytest workaround thing.
Codecov Report
@@ Coverage Diff @@
## edge #9773 +/- ##
=======================================
Coverage 75.24% 75.24%
=======================================
Files 1979 1979
Lines 52173 52173
Branches 5044 5044
=======================================
Hits 39258 39258
Misses 11949 11949
Partials 966 966
Flags with carried forward coverage won't be shown. Click here to find out more. |
mcous
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds the
sqlalchemy2-stubspackage as a robot-server dev dependency.Background
The SQLAlchemy type-checking situation seems pretty bad:
SQLAlchemy 2 promises to do it right, but there's no scheduled release date for it.
SQLAlchemy 1.4 appears to require at least standalone stubs, plus maybe also a mypy plugin.
sqlalchemy2-stubsis the official solution, despite being proclaimed in various places to be unstable. (It "should now be considered as legacy, even though it is still necessary for full Mypy support when using SQLAlchemy 1.4." 🙃)There's also
sqlalchemy-stubs(without the2), a more mature set of stubs published by DropBox. However, its support for SQLAlchemy 1.4 seems spotty.Review requests
sqlalchemy2-stubsis the least bad option, for now?Risk assessment
No risk to production code. This just adds a dev dependency.