chore(robot-server): Experiments with hanging robot-server tests in CI #16306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tocols (#16171) Closes RQA-3118 # Overview The check for matching RTPs had a bug where if a protocol had no RTPs, it would deem that protocol to have 'no previously matching analyses' and hence would always re-analyze the protocol, even when the protocol has not changed. This PR fixes that check and adds tests so that we'll know if it happens again. Fixing this bug revealed another bug that the legacy context plugin task being created while setting up the protocol runner, was never being stopped/ cancelled, hence preventing the server from shutting down. To fix that, I am stopping the orchestrator when the analyzer's destructor is called. ## Test Plan and Hands on Testing Follow the instructions in the RQA ticket above and see that the erroneous behavior is not seen. ## Review requests - check that the tests cover all cases of analyzing RTP & non-RTP protocols with various combinations of new and previous parameters (if any) ## Risk assessment Medium. Bug fix, but need to make sure that all combinations of possible protocol analysis params are covered. Also affects server shutdown. --------- Co-authored-by: Josh McVey <[email protected]> (cherry picked from commit b0b8221)
SyntaxColoring
changed the title
SyntaxColoring
changed the title
SyntaxColoring
changed the title
This reverts commit d207af3.
SyntaxColoring
added
the
DO NOT MERGE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experiments to fix the robot-server tests hanging in CI. See EXEC-714.