-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): Update absorbance reader driver namespace for byonoy_devices library version 2024.9.0 #16289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
…nitialize.py typos Co-authored-by: Ed Cormany <[email protected]>
update api doc
vegano1
force-pushed
the
PLAT-382-update-byonoy-lib
branch
from
September 19, 2024 14:26
5949035
to
fb8b39b
Compare
update api doc
…nitialize.py typos Co-authored-by: Ed Cormany <[email protected]>
vegano1
force-pushed
the
PLAT-382-update-byonoy-lib
branch
from
September 19, 2024 14:31
fb8b39b
to
8417fe3
Compare
ahiuchingau
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah very nice!!!
CaseyBatten
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks clean and makes sense based on the changes we've discussed that byonoy is making in their nomenclature.
vegano1
added a commit
that referenced
this pull request
Sep 23, 2024
…es library version 2024.9.0 (#16289)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We got a new 2024.09.0 library update from Byonoy, this pull request updates the function names and error codes to reflect the new library names. This pull request goes in conjunction with this oe-core pr Opentrons/oe-core#167.
Library Introduces the following changes
`There are two major changes.
There are some bug fixes
Test Plan and Hands on Testing
Changelog
AbsorbanceHidInterface
functions to match that of the new libraryErrorCodeNames
to match the new libraryREF:
in the response.Review requests
Risk assessment
Low, unreleased