fix(api): Restrict 96ch single tip pickup to only support 1000ul #16195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y3rsh
added
the
DO NOT MERGE
|
Testing on alpha.5 looked good. Added label but not closing yet. |
CaseyBatten
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR should only be merged if it is deemed by hardware testing that allowing the 96ch to pickup 50ul tips in single channel pickup configuration would cause damage or undesired behavior.
This PR introduces a "NotImplementedError" for the specific case mentioned above. All other 96ch configurations support 50ul tips. All 8ch configurations support 50ul tips.
Test Plan and Hands on Testing
Ensure that no other configuration/tip type pair has been interuppted by this.
Ensure that we raise an error during analysis
Ensure that we raise an error on robot-side analysis
Changelog
Introduced a new error case to the engine side pick up tip function.
Review requests
If hardware testing and QA agree that this is appropriate, feel free to review and merge.
Risk assessment
Low - forbids a new edge case feature we were introducing.