ref: Privatize and Rename State Fields

[0xNeshi]

Resolves #447, resolves #386

PR Checklist

• Tests
• Documentation
• Changelog

[netlify]

✅ Deploy Preview for contracts-stylus canceled.

Name	Link
🔨 Latest commit	16fbe67
🔍 Latest deploy log	https://app.netlify.com/sites/contracts-stylus/deploys/678a2d642834a600080cc72e

[codecov]

Codecov Report

Attention: Patch coverage is 96.38554% with 9 lines in your changes missing coverage. Please review.

Project coverage is 87.6%. Comparing base (e005e5b) to head (16fbe67).

Files with missing lines	Patch %	Lines
contracts/src/finance/vesting_wallet.rs	80.0%	2 Missing ⚠️
contracts/src/token/erc20/extensions/metadata.rs	0.0%	2 Missing ⚠️
contracts/src/token/erc721/extensions/metadata.rs	33.3%	2 Missing ⚠️
contracts/src/utils/metadata.rs	0.0%	2 Missing ⚠️
...ontracts/src/token/erc721/extensions/enumerable.rs	94.4%	1 Missing ⚠️

Additional details and impacted files

Files with missing lines	Coverage Δ
contracts/src/access/control.rs	98.0% <100.0%> (-0.1%)	⬇️
contracts/src/access/ownable.rs	93.0% <100.0%> (ø)
contracts/src/access/ownable_two_step.rs	98.4% <100.0%> (ø)
contracts/src/token/erc1155/extensions/burnable.rs	100.0% <100.0%> (ø)
...racts/src/token/erc1155/extensions/metadata_uri.rs	72.0% <100.0%> (ø)
contracts/src/token/erc1155/extensions/supply.rs	80.8% <100.0%> (ø)
...tracts/src/token/erc1155/extensions/uri_storage.rs	98.0% <100.0%> (ø)
contracts/src/token/erc1155/mod.rs	96.8% <100.0%> (ø)
contracts/src/token/erc20/extensions/burnable.rs	100.0% <100.0%> (ø)
contracts/src/token/erc20/extensions/capped.rs	76.9% <100.0%> (ø)
... and 18 more

[bidzyyys]

Looks much better!

[bidzyyys]

Why pub for private function?

[0xNeshi]

One reason is that after the change the compiler started complaining that this function and the field with the same name were unused.

Another reason is that I looked at the Solidity version, and the only truly private function is _nextConsecutiveId - all of the other functions are internal, e.g. see _maxBatchSize

If we are to keep compatibility with Solidity, fn _first_consecutive_id should be marked as pub too (see _firstConsecutiveId)