-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use stylus-proc indirectly #298
Conversation
✅ Deploy Preview for contracts-stylus canceled.
|
9623632
to
bb318a1
Compare
…ectly # Conflicts: # contracts/src/token/erc20/extensions/metadata.rs # contracts/src/token/erc20/mod.rs # contracts/src/token/erc721/extensions/enumerable.rs # contracts/src/token/erc721/extensions/metadata.rs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I am curious if we can do the same with alloy
(no to have additional dependency for our contracts, only for tests).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just left a small nit 🤓
stylus-sdk
already reexports matchingstylus-proc
version. Make sense to simplify dependencies a bit and use reexported library everywhere.