Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use stylus-proc indirectly #298

Merged
merged 6 commits into from
Oct 2, 2024
Merged

Conversation

qalisander
Copy link
Member

@qalisander qalisander commented Sep 24, 2024

stylus-sdk already reexports matching stylus-proc version. Make sense to simplify dependencies a bit and use reexported library everywhere.

Copy link

netlify bot commented Sep 24, 2024

Deploy Preview for contracts-stylus canceled.

Name Link
🔨 Latest commit 94b8126
🔍 Latest deploy log https://app.netlify.com/sites/contracts-stylus/deploys/66fd8001305a300008a979df

@qalisander qalisander changed the title chore: use stylus proc indirectly chore: use stylus-proc indirectly Sep 24, 2024
@qalisander qalisander marked this pull request as ready for review September 24, 2024 16:59
…ectly

# Conflicts:
#	contracts/src/token/erc20/extensions/metadata.rs
#	contracts/src/token/erc20/mod.rs
#	contracts/src/token/erc721/extensions/enumerable.rs
#	contracts/src/token/erc721/extensions/metadata.rs
Copy link
Collaborator

@bidzyyys bidzyyys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I am curious if we can do the same with alloy (no to have additional dependency for our contracts, only for tests).

Copy link
Collaborator

@ggonzalez94 ggonzalez94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just left a small nit 🤓

README.md Outdated Show resolved Hide resolved
@qalisander qalisander merged commit dce09d3 into main Oct 2, 2024
22 checks passed
@bidzyyys bidzyyys deleted the use-stylus-proc-indirectly branch October 15, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants