ref: new workspace structure and version management #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…267) Add the rc tag to the docs so we can publish them before the audit. It should be shown as `0.1.0-rc` on the site. I also made clear in the warning that this hasn't been audited yet. Signed-off-by: Gustavo Gonzalez <[email protected]>
Bump version to `0.1.0-rc`.
Bump: - Stylus SDK to `v0.6.0` - cargo-stylus to `v0.5.1`
qalisander
reviewed
Sep 11, 2024
lib/motsu/Cargo.toml
Outdated
|
|
||
| [dependencies] | ||
| const-hex.workspace = true | ||
| once_cell.workspace = true | ||
| tiny-keccak.workspace = true | ||
| stylus-sdk.workspace = true | ||
| motsu-proc = { path = "../motsu-proc" } | ||
| motsu-proc = "0.1.0" |
There was a problem hiding this comment.
I think If we change smth in motsu-proc crate we need to see those changes inside motsu without publishing crate
There was a problem hiding this comment.
Can you try to add version altogether with path?
✅ Deploy Preview for contracts-stylus canceled.
|
bidzyyys
force-pushed
the
build/motsu-version
branch
from
30a788b
to
cf154e5
Compare
bidzyyys
force-pushed
the
build/motsu-version
branch
from
cf154e5
to
7a70440
Compare
…tes.io (cherry picked from commit 16937a2)
bidzyyys
force-pushed
the
build/motsu-version
branch
from
2ea0930
to
9622dc5
Compare
qalisander
approved these changes
Sep 18, 2024
| CARGO_TERM_COLOR: always | ||
| jobs: | ||
| check-publish: | ||
| name: Check publish on crates.io |
There was a problem hiding this comment.
But I would change the pr's name to ref: ...
There was a problem hiding this comment.
@qalisander how about ref: new workspace structure
bidzyyys
changed the title
ggonzalez94
reviewed
Sep 20, 2024
| with: | ||
| target: wasm32-unknown-unknown | ||
| components: rust-src | ||
| toolchain: nightly-2024-01-01 |
There was a problem hiding this comment.
We define the version of the toolchain in main places across workflows. I wonder if it would be better to specify it in rust-toolchain.toml file and then:
- Actions can just use that version
- Everyone that runs the project locally will use the same version of the toolchain
ggonzalez94
reviewed
Sep 20, 2024
| openzeppelin-stylus = { path = "contracts" } | ||
| openzeppelin-crypto = { path = "lib/crypto" } | ||
| motsu = { path = "lib/motsu"} | ||
| motsu-proc = { path = "lib/motsu-proc", version = "0.1.0" } |
There was a problem hiding this comment.
Why do we set a specific version for motsu-proc? Is this intentional?
There was a problem hiding this comment.
Needed to publish motsu to crates.io; requirement for cargo publish -p motsu --dry-run
2 tasks
qalisander
pushed a commit
that referenced
this pull request
Oct 4, 2024
- [x] Set `motsu` version to `v0.1.0`
- [x] Improve version management for the workspace
- `contracts`, `lib/crypto`, `examples`, and `benches` use version set
for the whole workspace
- `motsu`, `motsu-proc`, `e2e`, `e2e-proc` have their own version per
crate
- [x] Cleanup dependencies for the workspace
- [x] Add CI checks for pre-publishing on crates.io
- [x] Fix issues with publishing `motsu` to crates.io:
```
cargo publish -p motsu --target wasm32-unknown-unknown --dry-run
Updating crates.io index
error: all dependencies must have a version specified when publishing.
dependency `motsu-proc` does not specify a version
Note: The published dependency will use the version from crates.io,
the `path` specification will be removed from the dependency declaration.
```
---------
(cherry picked from commit b1eef80)
qalisander
pushed a commit
that referenced
this pull request
Oct 9, 2024
- [x] Set `motsu` version to `v0.1.0`
- [x] Improve version management for the workspace
- `contracts`, `lib/crypto`, `examples`, and `benches` use version set
for the whole workspace
- `motsu`, `motsu-proc`, `e2e`, `e2e-proc` have their own version per
crate
- [x] Cleanup dependencies for the workspace
- [x] Add CI checks for pre-publishing on crates.io
- [x] Fix issues with publishing `motsu` to crates.io:
```
cargo publish -p motsu --target wasm32-unknown-unknown --dry-run
Updating crates.io index
error: all dependencies must have a version specified when publishing.
dependency `motsu-proc` does not specify a version
Note: The published dependency will use the version from crates.io,
the `path` specification will be removed from the dependency declaration.
```
---------
(cherry picked from commit b1eef80)
ggonzalez94
pushed a commit
that referenced
this pull request
Oct 14, 2024
- [x] Set `motsu` version to `v0.1.0`
- [x] Improve version management for the workspace
- `contracts`, `lib/crypto`, `examples`, and `benches` use version set
for the whole workspace
- `motsu`, `motsu-proc`, `e2e`, `e2e-proc` have their own version per
crate
- [x] Cleanup dependencies for the workspace
- [x] Add CI checks for pre-publishing on crates.io
- [x] Fix issues with publishing `motsu` to crates.io:
```
cargo publish -p motsu --target wasm32-unknown-unknown --dry-run
Updating crates.io index
error: all dependencies must have a version specified when publishing.
dependency `motsu-proc` does not specify a version
Note: The published dependency will use the version from crates.io,
the `path` specification will be removed from the dependency declaration.
```
---------
(cherry picked from commit b1eef80)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motsuversion tov0.1.0contracts,lib/crypto,examples, andbenchesuse version set for the whole workspacemotsu,motsu-proc,e2e,e2e-prochave their own version per cratemotsuto crates.io: