Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ignoring Hardhat compile errors when extracting detailed namespaced storage layouts for validations #1090

Merged
merged 10 commits into from
Oct 10, 2024

Conversation

ericglau
Copy link
Member

@ericglau ericglau commented Oct 4, 2024

Fixes #1088

Support ignoring Hardhat compile errors when extracting detailed namespaced storage layouts for validations.

This can be done by setting the new option namespacedCompileErrors in the hardhat config, which supports error (default), warn, or ignore.

For example:

module.exports = {
  namespacedCompileErrors: 'warn',
};

or

module.exports = {
  namespacedCompileErrors: 'ignore',
};

Copy link

socket-security bot commented Oct 4, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/@openzeppelin/[email protected]

View full report↗︎

@ericglau ericglau changed the title Support ignoring Hardhat compile errors when extracting detailed namespaced storage layouts for validations. Support ignoring Hardhat compile errors when extracting detailed namespaced storage layouts for validations Oct 4, 2024
@ericglau ericglau marked this pull request as ready for review October 4, 2024 21:47
@ericglau ericglau requested review from a team and frangio October 4, 2024 21:47
Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ericglau!

@ericglau ericglau removed the request for review from frangio October 10, 2024 03:28
@ericglau ericglau merged commit 08c6cd4 into OpenZeppelin:master Oct 10, 2024
13 of 14 checks passed
@ericglau ericglau deleted the 1087 branch October 10, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow namespaced compilation failures to be ignored
2 participants