Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor use _validateCancel #5425

Closed
wants to merge 20 commits into from
Closed

refactor use _validateCancel #5425

wants to merge 20 commits into from

Conversation

arr00
Copy link
Contributor

@arr00 arr00 commented Jan 10, 2025

Fixes #????

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 10, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: f83d972

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

ernestognw
ernestognw reviewed Jan 10, 2025
View reviewed changes
Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how it looks

contracts/governance/Governor.sol Show resolved Hide resolved
contracts/governance/Governor.sol Outdated Show resolved Hide resolved
@arr00 arr00 force-pushed the refactor/cancel-validate-cancel branch from 446b171 to 13f18c5 Compare January 22, 2025 03:25
@arr00 arr00 force-pushed the refactor/cancel-validate-cancel branch from e65a38a to ce162a6 Compare January 22, 2025 23:35
@arr00 arr00 closed this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ernestognw ernestognw ernestognw left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arr00 @ernestognw @Amxx