Remove Arrays library usage from EnumerableSetExtended
#122
+16
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Given that each function is called just once, does it not make sense to inline the assembly? |
arr00
reviewed
Apr 25, 2025
Yeah that makes sense. Updated |
arr00
reviewed
Apr 25, 2025
arr00
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unfortunately, OpenZeppelin/openzeppelin-contracts@8a4eade didn't make it into the 5.3.0 release, which makes available some changes needed for the
EnumerableSetExtendedlibrary. Concretely, theunsafeSetLengthfunctions are not available to users.As a result, OpenZeppelin/contracts-wizard#527 do not compile. This PR addresses the issue by temporarily porting the missing features in 5.3.0