Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump snforge, unignore tests #1203

Merged
merged 8 commits into from
Nov 13, 2024

Conversation

andrew-fleming
Copy link
Collaborator

Bump snforge to v0.33.0 which allows some of the previously ignored tests to successfully run (namely, ENTRYPOINT_NOT_FOUND tests with dispatchers). It might be worth waiting for the package release on scarbs before merging

PR Checklist

  • Tests
  • [ ] Documentation
  • [ ] Added entry to CHANGELOG.md
  • [ ] Tried the feature on a public network

@andrew-fleming andrew-fleming marked this pull request as draft November 8, 2024 00:55
@ericnordelo
Copy link
Member

Great news @andrew-fleming. The PR looks good to me, but let's not forget to add the CHANGELOG entry for bumping the snfoundry version.

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.03%. Comparing base (6e3d8aa) to head (26153f8).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1203   +/-   ##
=======================================
  Coverage   92.03%   92.03%           
=======================================
  Files          49       49           
  Lines        1394     1394           
=======================================
  Hits         1283     1283           
  Misses        111      111           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e3d8aa...26153f8. Read the comment docs.

@andrew-fleming andrew-fleming marked this pull request as ready for review November 12, 2024 20:22
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@ericnordelo ericnordelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a small comment. LGTM otherwise.

@andrew-fleming andrew-fleming merged commit 399654f into OpenZeppelin:main Nov 13, 2024
8 checks passed
@andrew-fleming andrew-fleming deleted the bump-foundry branch November 13, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants