-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump snforge, unignore tests #1203
Bump snforge, unignore tests #1203
Conversation
Great news @andrew-fleming. The PR looks good to me, but let's not forget to add the CHANGELOG entry for bumping the snfoundry version. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1203 +/- ##
=======================================
Coverage 92.03% 92.03%
=======================================
Files 49 49
Lines 1394 1394
=======================================
Hits 1283 1283
Misses 111 111 Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a small comment. LGTM otherwise.
Co-authored-by: Eric Nordelo <[email protected]>
Bump snforge to v0.33.0 which allows some of the previously ignored tests to successfully run (namely,
ENTRYPOINT_NOT_FOUND
tests with dispatchers). It might be worth waiting for the package release on scarbs before mergingPR Checklist
[ ] Documentation[ ] Added entry to CHANGELOG.md[ ] Tried the feature on a public network