Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coverage to our test workflow #1152

Merged
merged 12 commits into from
Sep 20, 2024
Merged

Add coverage to our test workflow #1152

merged 12 commits into from
Sep 20, 2024

Conversation

ggonzalez94
Copy link
Collaborator

Fixes #1129

Description

  • Add --coverage flag to the test step
  • Upload report to codecov(token is already configured in GH secrets)
  • Format the workflow file to make it more readable

I was planning to add this in our next milestone, but it was much easier than I expected. I tested it on my branch and the coverage report was generated and uploaded to codecov, but since cairo-coveragedoes not support branch coverage yet, I don't know exactly what the final report looks like(we will see once it is merged to main)

@ericnordelo
Copy link
Member

Should we define rules and add a codecov configuration file similar to what we have in solidity?

@ggonzalez94
Copy link
Collaborator Author

@ericnordelo it is not needed to have an initial coverage report, but I did take the opportunity and added a codecov.ymlfile to the repo which should make things better. Let me know what you think. Once we have more data we should refine what our thresholds are.

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.35%. Comparing base (387637e) to head (ec7fc8e).
Report is 159 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##           main    #1152       +/-   ##
=========================================
+ Coverage      0   89.35%   +89.35%     
=========================================
  Files         0       55       +55     
  Lines         0     1334     +1334     
=========================================
+ Hits          0     1192     +1192     
- Misses        0      142      +142     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bac08ee...ec7fc8e. Read the comment docs.

Copy link
Member

@ericnordelo ericnordelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

codecov.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@andrew-fleming andrew-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I just left a question

codecov.yml Show resolved Hide resolved
@ggonzalez94 ggonzalez94 merged commit 4e40ad4 into main Sep 20, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Measure test coverage
3 participants