Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OutsideExecution (SNIP-9) #1150

Merged
merged 14 commits into from
Sep 20, 2024
Merged

Conversation

ericnordelo
Copy link
Member

@ericnordelo ericnordelo commented Sep 16, 2024

Fixes #1110

PR Checklist

  • Tests
  • Documentation
  • Added entry to CHANGELOG.md
  • Tried the feature on a public network

@ericnordelo ericnordelo marked this pull request as ready for review September 18, 2024 12:26
Copy link
Collaborator

@andrew-fleming andrew-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks really good, Eric! I left some minor comments and questions

docs/modules/ROOT/pages/api/account.adoc Outdated Show resolved Hide resolved
packages/account/src/extensions/src9/snip12_utils.cairo Outdated Show resolved Hide resolved
packages/account/src/extensions/src9/interface.cairo Outdated Show resolved Hide resolved
packages/account/src/tests/extensions/test_src9.cairo Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/api/account.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/api/account.adoc Outdated Show resolved Hide resolved
Copy link
Collaborator

@immrsd immrsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, Eric! Left a couple of suggestions

packages/account/src/extensions/src9/src9.cairo Outdated Show resolved Hide resolved
packages/account/src/extensions/src9/src9.cairo Outdated Show resolved Hide resolved
packages/account/src/extensions/src9/src9.cairo Outdated Show resolved Hide resolved
@immrsd
Copy link
Collaborator

immrsd commented Sep 20, 2024

What do you think about adding SRC-9 to account presets?

Copy link
Collaborator

@immrsd immrsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ericnordelo
Copy link
Member Author

What do you think about adding SRC-9 to account presets?

I think we should add it to wizard, not to presets. In general, presets are a temporary solution to examples out of wizard, but we should always favor wizard, and we should avoid a situation where we start adding many presets, even when some of them are useful.

Copy link
Collaborator

@andrew-fleming andrew-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ericnordelo ericnordelo merged commit be991c0 into OpenZeppelin:main Sep 20, 2024
6 checks passed
@ericnordelo ericnordelo deleted the feat/snip-9-#1110 branch September 20, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementation of SNIP-9
3 participants