-
Notifications
You must be signed in to change notification settings - Fork 523
Fix PresentationBuilder resource leak #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: vNext
Are you sure you want to change the base?
Conversation
Merge Himanshu's fix into the repository: https://github.com/EricWhiteDev/Open-Xml-PowerTools/pull/15/files Related work items: #7998
One possible stacktrace... My fix closes about 12 leaks. I have only one path here.
|
@Lotes thanks for saving me some work with your fix! Since this fork doesn't seem to be maintained, is there any chance we could direct your fix towards another actively maintained fork? Looking over the forks, I see that https://github.com/Codeuctivity/OpenXmlPowerTools might be a candidate. @stesee could you shed some light on the status of that fork and its willingness to accept other PRs? Thank you! |
Status: Pet Project |
FYI, we decided to go a different route but I appreciate your quick responses. Thank you guys! |
…ocumentFormat.OpenXml-2.14.0 Bump DocumentFormat.OpenXml from 2.13.1 to 2.14.0
You need to dispose the stream. Otherwise when two parts use the same resource it will complain about multiple opened streams when package is in "UpdateMode". This change was done on top of Pullrequest #15.