fix(TP): fix hardcoding issues in Common.scala to support sv48 #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace magic numbers(hardcoding issues) with variable in calss TPmetaReq & TPmetaResp; support sv48(avoid assertion fail)
Ivyfeather
approved these changes
Sep 3, 2024
Ma-YX
added a commit
that referenced
this pull request
Sep 5, 2024
Bug: TPmetaReq/Resp cannot get fullAddressBits from EdgeIn/OutKey in CoupledL2, since they are defined in HuanCun(Caused by pr #180) Solution: use certain parameters for TPmetaReq/Resp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace magic numbers(hardcoding issues) with variable in calss TPmetaReq & TPmetaResp; support sv48(avoid assertion fail)