Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COC] Support usage of multiple spawn_loadout sections in character descriptions. #1590

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

Neloreck
Copy link
Contributor

@Neloreck Neloreck commented Jan 17, 2024

Allows addition of sections spawn_loadout, spawn_loadout2 ... spawn_loadoutN for stalkers items randomization.
Definition of rifle + pistol character description becomes simpler and more readable.

Related

#1529

Changes

  • Similar to CoC support few loadouts in character description
  • Reformat code with clang-format

Todo / future


Regarding script callback:

  • In CoC it has very specific name, CSE_ALifeObject_spawn_supplies - prettier/shorter variant could be used
  • In CoC it is bound to ai_stalker file

It is just few lines of code, but I am not sure about naming of the callback.

@Neloreck Neloreck marked this pull request as ready for review January 17, 2024 23:40

loadout_index += 1;
string32 buf;
loadout_section = strconcat(sizeof(buf), buf, "spawn_loadout", std::to_string(loadout_index).c_str());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xr_sprintf(loadout_section, "spawn_loadout%d", loadout_index);

@Xottab-DUTY Xottab-DUTY added the Modmaker Experience Modmaker experience with OpenXRay label Jan 28, 2024
OneMorePseudoCoder added a commit to OneMorePseudoCoder/OXR_CoC_New that referenced this pull request Feb 21, 2024
-Support usage of multiple spawn_loadout sections in character descriptions (OpenXRay#1590)
-Support for linear space rendering in R4 renderer (OpenXRay#1576)
-Fixed "Naruto run"
-Fog affects npc vision
-Smopth peak
-Landscape render phase (IXRAY)
-Volumetric light optimization (fixed light flickering by Graff46)
-Fixed visual memory manager formula
-Optimazed light renderer (https://github.com/OpenXRay/xray-16/pull/1600/files)
-Fixed HOM cache (dsh2dsh)
-Fixed CKinematics::LL_SetBoneVisible (Anomaly)
OneMorePseudoCoder added a commit to OneMorePseudoCoder/OXR_CoC_New that referenced this pull request Feb 22, 2024
-Support usage of multiple spawn_loadout sections in character descriptions (OpenXRay#1590)
-Support for linear space rendering in R4 renderer (OpenXRay#1576)
-Fixed "Naruto run"
-Fog affects npc vision
-Smopth peak
-Landscape render phase (IXRAY)
-Volumetric light optimization (fixed light flickering by Graff46)
-Fixed visual memory manager formula
-Optimazed light renderer (https://github.com/OpenXRay/xray-16/pull/1600/files)
-Fixed HOM cache (dsh2dsh)
-Fixed CKinematics::LL_SetBoneVisible (Anomaly)
@Xottab-DUTY Xottab-DUTY force-pushed the dev branch 2 times, most recently from 5b2ec76 to 6fffce9 Compare May 4, 2024 03:27
@Xottab-DUTY Xottab-DUTY force-pushed the dev branch 2 times, most recently from e89fcc8 to f6fd5cc Compare October 24, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Modmaker Experience Modmaker experience with OpenXRay
Projects
Status: To do
Development

Successfully merging this pull request may close these issues.

3 participants