-
-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Adding ini_file luabind constructor override. #1401
[Feature] Adding ini_file luabind constructor override. #1401
Conversation
4781b9e
to
966e008
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks similar feature to Anomaly, although, it's a bit different.
Could we make it the same as in Anomaly?
@Xottab-DUTY
In my variant I just simply add one more constructor for luabind ini file to open files not only from default configs folder. Regarding monolith engine: https://bitbucket.org/anomalymod/xray-monolith/src/d369db0ce75b8101c8d0fe1b2fa7a84b04910a35/src/xrServerEntities/script_ini_file.cpp#lines-20 I believe similar approach is used here, but in anomaly variant override adds one optional parameter in the list end. If it is provided, it simply ignores first parameter with ternary operator. What I would do as next steps:
|
There is also thing called DXML: https://github.com/themrdemonized/STALKER-Anomaly-modded-exes/blob/main/DXML.md Did anyone ever proposed DLTX / DXML integration? |
It would be helpful, if we want to make life life easier for modders, that are used to Anomaly features. So, my initial suggestion had only a small scope of this: only adding function override like in Anomaly :)
I fully support this, especially since we have #1373 :) |
I will add one more override to match anomaly as soon, as I have time then |
Anomaly matching constructor will be merged as a part of the Call of Chernobyl code merge, so I reverted it here to help merging process a bit. Thank you! |
Adding additional constructor override for ini_file luabind export class.
As result, modders will be able to create ini files placed not only in gamedata/configs folder.
In my case it may be useful for
extensions
feature, where separate extensions can be packed as script+ltx files without file system conflicts.Changes: