fix/plugin_stream_extraction

[JarbasAl]

fix update method type check

validate that required sei are available

ensure metadata is not dropped by the plugin

Summary by CodeRabbit

• New Features

  • Expanded support for additional entry types in the update process.
  • Enhanced error handling for extractor availability in media extraction.

• Bug Fixes

  • Improved default value assignment for playback types in the media entry extraction.

These updates enhance the application's flexibility and robustness, ensuring a smoother user experience when handling media entries.

[coderabbitai]

Walkthrough

The recent updates enhance the ovos_utils/ocp.py file by improving the update and extract_media_entry methods. The update method now supports additional entry types, increasing flexibility. Meanwhile, extract_media_entry introduces robust error handling, ensuring valid extractors are used and setting default playback types. Together, these changes refine the way media entries are processed and managed, improving code resilience and functionality.

Changes

File	Change Summary
ovos_utils/ocp.py	Expanded type checks in update to include PluginStream. Enhanced extract_media_entry with error handling for extractors and default playback logic.

Poem

In the code where rabbits roam,
New updates make it feel like home.
With plugins hopping left and right,
Media entries dance in delight.
Error handling, a joyful tune,
Let's celebrate under the coding moon! 🐰✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 42.39%. Comparing base (b90285c) to head (3a50f9e).
Report is 2 commits behind head on dev.

Files	Patch %	Lines
ovos_utils/ocp.py	0.00%	9 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #263      +/-   ##
==========================================
- Coverage   42.49%   42.39%   -0.11%     
==========================================
  Files          31       31              
  Lines        3219     3227       +8     
==========================================
  Hits         1368     1368              
- Misses       1851     1859       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c3a52d0 and 3a50f9e.

Files selected for processing (1)

• ovos_utils/ocp.py (2 hunks)

Additional comments not posted (2)

ovos_utils/ocp.py (2)

281-291: LGTM! But verify the function usage in the codebase.

The code changes are approved.

However, ensure that all function calls to extract_media_entry handle the new error handling and playback type logic correctly.

---

180-180: LGTM! But verify the function usage in the codebase.

The code changes are approved.

However, ensure that all function calls to update handle the new type PluginStream correctly.