chore: clean up types, address name overwrite #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JarbasAl Is there a particular reason to pin rapidfuzz to 3.6.x, or was that just Dependabot going wild? Are there features we need in utils that are only available in the newest version? Did we drop compat with 2.x? I ask because that version isn't available for Python 3.7...it's causing test failures |
|
Converting to a draft, because this has the potential to be very breaking, and Jarbas suggested maybe we deprecate portions of it anyway. This shouldn't merge until after ovos-core 0.0.8 is released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #214