Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volunteer GUI upload on init #178

Merged
merged 4 commits into from
Jul 7, 2023
Merged

Volunteer GUI upload on init #178

merged 4 commits into from
Jul 7, 2023

Conversation

NeonDaniel
Copy link
Member

Adds message emit on interface init to notify GUI when resources are available to upload
Adds handling in upload_gui_pages to skip requests for specific skills other than this one

@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #178 (1993804) into dev (a4ef6ae) will increase coverage by 0.05%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##              dev     #178      +/-   ##
==========================================
+ Coverage   27.63%   27.69%   +0.05%     
==========================================
  Files          49       49              
  Lines        6452     6457       +5     
==========================================
+ Hits         1783     1788       +5     
  Misses       4669     4669              
Impacted Files Coverage Δ
ovos_utils/version.py 0.00% <0.00%> (ø)
ovos_utils/gui.py 47.27% <100.00%> (+0.51%) ⬆️

@NeonDaniel NeonDaniel marked this pull request as ready for review July 7, 2023 21:40
@NeonDaniel NeonDaniel merged commit 0a7ff8c into dev Jul 7, 2023
10 checks passed
@NeonDaniel NeonDaniel deleted the FEAT_VolunteerGUIPageUpload branch July 7, 2023 22:31
@github-actions github-actions bot mentioned this pull request Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants