Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:lang2voice #3

Merged
merged 1 commit into from
Sep 26, 2024
Merged

feat:lang2voice #3

merged 1 commit into from
Sep 26, 2024

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Sep 26, 2024

Summary by CodeRabbit

  • New Features

    • Introduced a language parameter for text-to-speech conversion, allowing users to specify the desired language.
    • Enhanced voice selection process to automatically assign the first available voice based on the specified language.
  • Bug Fixes

    • Improved functionality of the text-to-speech method to ensure seamless audio chunk delivery.

Copy link

coderabbitai bot commented Sep 26, 2024

Walkthrough

The changes introduce an additional parameter, lang, to the stream_tts method in the EdgeTTSPlugin class, enabling language specification for text-to-speech conversion. If lang is provided without a corresponding voice, the method will standardize the language tag and select the first available voice from the VOICES dictionary. The method continues to yield audio chunks as they become available. A new instance of EdgeTTSPlugin is created in the if __name__ == "__main__": block, demonstrating the use of the get_tts method with the new lang parameter.

Changes

Files Change Summary
ovos_tts_plugin_edge_tts/init.py Updated stream_tts method signature to include lang. Added logic to handle language and voice selection. New instance creation in if __name__ == "__main__":.

Poem

In a world of voices, bright and clear,
A rabbit hops with joy and cheer.
With languages new, our tales will sing,
Text-to-speech magic, what joy it brings!
Hopping along with a happy sound,
In every language, our dreams abound! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added feature and removed feature labels Sep 26, 2024
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (1)
ovos_tts_plugin_edge_tts/__init__.py (1)

181-193: LGTM! Consider adding error handling for unsupported languages.

The changes to the stream_tts method look good. The new lang parameter adds flexibility by allowing language-based voice selection when no specific voice is provided. The implementation correctly standardizes the language tag and selects the first available voice for that language.

Consider adding error handling for cases where the provided lang is not in the VOICES dictionary. This would improve the robustness of the method. For example:

if lang and not voice:
    lang = standardize_lang_tag(lang, macro=True)
    if lang in VOICES:
        voice = VOICES[lang][0]
    else:
        raise ValueError(f"Unsupported language: {lang}")
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between a66c1d9 and bb78d8d.

📒 Files selected for processing (1)
  • ovos_tts_plugin_edge_tts/init.py (1 hunks)
🔇 Additional comments (1)
ovos_tts_plugin_edge_tts/__init__.py (1)

Line range hint 1-199: Overall, the changes look good with room for minor improvements.

The modifications to the EdgeTTSPlugin class, particularly the stream_tts method, enhance its functionality by adding language-based voice selection. The new main block provides a basic usage example. The suggested improvements, if implemented, would further increase the robustness and demonstrative value of the code.

🧰 Tools
🪛 Ruff

179-179: Ambiguous variable name: l

(E741)


179-179: Use key in dict instead of key in dict.keys()

Remove .keys()

(SIM118)

ovos_tts_plugin_edge_tts/__init__.py Show resolved Hide resolved
@JarbasAl JarbasAl merged commit 8dc97d7 into dev Sep 26, 2024
3 of 6 checks passed
@JarbasAl JarbasAl deleted the lang2voice branch September 26, 2024 14:27
JarbasAl added a commit that referenced this pull request Sep 26, 2024
was defaulting to "wav" but files are mp3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant