-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/triples_plugins #257
feat/triples_plugins #257
Conversation
add base class for handling triples extraction from text
WalkthroughThe recent changes introduce a new abstract class Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
example usage TigreGotico/ovos-coreferee-plugin#1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- ovos_plugin_manager/templates/triples.py (1 hunks)
- ovos_plugin_manager/triples.py (1 hunks)
- ovos_plugin_manager/utils/init.py (2 hunks)
Additional comments not posted (7)
ovos_plugin_manager/templates/triples.py (1)
6-14
: Well-structured base class for triples extraction.The
TriplesExtractor
class is well-defined with clear responsibilities:
- The constructor initializes configuration and sets a default token.
- The abstract method
extract_triples
is properly declared with a clear docstring and appropriate typing for its parameters and return type.ovos_plugin_manager/triples.py (4)
5-11
: Correct implementation of plugin discovery function.The function
find_triples_plugins
is correctly implemented with appropriate documentation and usage of utility functions to find plugins of typeCOREFERENCE_SOLVER
.
14-21
: Properly implemented plugin loading function.The function
load_triples_plugin
is well-documented and correctly uses a utility function to load a plugin based on the specified module name.
24-30
: Correct implementation for retrieving plugin configurations.The function
get_triples_configs
is correctly implemented with appropriate documentation and usage of utility functions to retrieve configurations for triples plugins.
33-40
: Properly implemented function for retrieving specific plugin configurations.The function
get_triples_module_configs
is well-documented and correctly uses a utility function to retrieve configurations for a specific triples plugin.ovos_plugin_manager/utils/__init__.py (2)
25-25
: Appropriate addition to thePluginTypes
enumeration.The new constant
TRIPLES
is correctly added with an appropriate value, following the existing naming conventions.
68-68
: Appropriate addition to thePluginConfigTypes
enumeration.The new constant
TRIPLES
is correctly added with an appropriate value, following the existing naming conventions.
add base class for handling triples extraction from text
Summary by CodeRabbit
New Features
TriplesExtractor
class for extracting semantic triples from documents.TRIPLES
constants for enhanced plugin management.Bug Fixes
Documentation